Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: OP finality-provider #8

Open
8 of 11 tasks
bap2pecs opened this issue Jul 31, 2024 · 2 comments
Open
8 of 11 tasks

EPIC: OP finality-provider #8

bap2pecs opened this issue Jul 31, 2024 · 2 comments

Comments

@bap2pecs bap2pecs added the EPIC label Jul 31, 2024
@bap2pecs
Copy link
Collaborator Author

@SebastianElvis commented on 2024-06-26:

QueryFinalityProviderVotingPower sounds good to me

The proposed QueryActivatedHeight might not work as the start_height is not necessarily the height that BTC delegation becomes active. To become active, it needs to satisfy 1) the staking tx is k-deep in Bitcoin, i.e., start_height + k and 2) it receives a quorum number of covenant committee signatures

@bap2pecs
Copy link
Collaborator Author

@bap2pecs commented on 2024-06-30:

note that for QueryFinalityProviderVotingPower, one problem is if we always return 1, it will cause issue


2024-06-29T17:15:40.891-0400	FATAL	service/fp_manager.go:110	terminating the finality-provider instance due to critical error	{"pk": "12b1058e00115ea41f28582db7fb684c03113933c630ffbfb5baea91beec6cc1", "error": "reached max failed cycles with err: failed to get inclusion proof of public randomness 983078c40dea8dfb765005d207092437f867bc881e1e45220cf15bfff2b056cd for FP 12b1058e00115ea41f28582db7fb684c03113933c630ffbfb5baea91beec6cc1 for block 2: public randomness proof not found"}

github.com/babylonchain/finality-provider/finality-provider/service.(*FinalityProviderManager).monitorCriticalErr

	/Users/zidong/Documents/Projects/babylon-finality-provider/finality-provider/service/fp_manager.go:110

FAIL	github.com/babylonchain/finality-provider/itest/opstackl2	58.684s

FAIL

due to submission loop trying to submit sig for a height missing PR. so we added https://github.com/babylonchain/babylon-contract/pull/196 and used it in QueryFinalityProviderVotingPower (see babylonchain/finality-provider#447)

@SebastianElvis SebastianElvis changed the title OP: finality-provider EPIC: OP finality-provider Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants