chore: Remove register-finality-provider cmd
#189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
requested review from
vitsalis,
SebastianElvis,
RafilxTenfen,
samricotta,
KonradStaniec,
Lazar955 and
filippos47
Lazar955
approved these changes
Dec 4, 2024
RafilxTenfen
reviewed
Dec 4, 2024
RafilxTenfen
reviewed
Dec 4, 2024
| return nil, fmt.Errorf("failed to create proof-of-possession of the finality-provider: %w", err) | ||
| } | ||
|
|
||
| // TODO: query consumer chain to check if the fp is already registered |
RafilxTenfen
approved these changes
Dec 4, 2024
samricotta
approved these changes
Dec 4, 2024
|
Local deployment works. Merging the pr now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188. In particular, this PR:
register-finality-providercmdcreate-finality-providerCREATEDapp.gotoevent_loops.go)As this PR caused major change in operations, please give it a careful look