Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CommitPubRand #225

Open
gitferry opened this issue Dec 16, 2024 · 0 comments · May be fixed by #233
Open

Refactor CommitPubRand #225

gitferry opened this issue Dec 16, 2024 · 0 comments · May be fixed by #233

Comments

@gitferry
Copy link
Member

CommitPubRand also includes saving all inclusion proofs of public randomness. This part should not be retried. We need to separate the function into:

  1. determining the starting height to commit
  2. generating pub rand and inclusion
  3. committing public randomness.
@gitferry gitferry mentioned this issue Dec 16, 2024
Merged
gitferry added a commit that referenced this issue Dec 16, 2024
@gitferry
chore: Remove todos (#221)
4f702d6 
Remaining todos are tracked by:
- #222
- #223
- #224
- #225
- #219
- #196
@gitferry gitferry linked a pull request Dec 19, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Refactor CommitPubRand babylonlabs-io/finality-provider
1 participant
@gitferry