From 65653016ab8f30206f761b299b0bacab641ff207 Mon Sep 17 00:00:00 2001 From: Cirrus Gai Date: Mon, 2 Dec 2024 18:28:51 +0800 Subject: [PATCH] chore: Change `btc_pk` text to `eots_pk` (#179) Closes #144 --- CHANGELOG.md | 1 + docs/finality-provider-operation.md | 4 ++-- .../cmd/fpd/daemon/daemon_commands.go | 16 +++++++++------- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 77dc7329..9aed4b62 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) ### Improvements * [#175](https://github.com/babylonlabs-io/finality-provider/pull/175) adds: `eotsd version` command +* [#179](https://github.com/babylonlabs-io/finality-provider/pull/179) Change `btc_pk` text to `eots_pk` in CLI ### Bug Fixes diff --git a/docs/finality-provider-operation.md b/docs/finality-provider-operation.md index 35f72d91..155afb59 100644 --- a/docs/finality-provider-operation.md +++ b/docs/finality-provider-operation.md @@ -548,7 +548,7 @@ your finality provider's details: The response includes: - `fp_addr`: Your Babylon account address of the finality provider -- `eots_pk_hex`: Your unique BTC public key identifier +- `eots_pk_hex`: Your unique EOTS public key identifier - `description`: Your finality provider's metadata - `commission`: Your set commission rate - `status`: Current status of the finality provider. @@ -665,4 +665,4 @@ removal from the active set. > ⚠️ **Critical**: Slashing is irreversible and results in > permanent removal from the network. - \ No newline at end of file + diff --git a/finality-provider/cmd/fpd/daemon/daemon_commands.go b/finality-provider/cmd/fpd/daemon/daemon_commands.go index 7e54b207..64a576a2 100644 --- a/finality-provider/cmd/fpd/daemon/daemon_commands.go +++ b/finality-provider/cmd/fpd/daemon/daemon_commands.go @@ -2,18 +2,20 @@ package daemon import ( "context" - "cosmossdk.io/math" "encoding/hex" "encoding/json" "fmt" + "strconv" + + "cosmossdk.io/math" "github.com/babylonlabs-io/babylon/types" - "github.com/babylonlabs-io/finality-provider/finality-provider/proto" "github.com/cosmos/cosmos-sdk/client" sdkflags "github.com/cosmos/cosmos-sdk/client/flags" stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types" "github.com/spf13/cobra" "github.com/spf13/pflag" - "strconv" + + "github.com/babylonlabs-io/finality-provider/finality-provider/proto" fpcmd "github.com/babylonlabs-io/finality-provider/finality-provider/cmd" fpcfg "github.com/babylonlabs-io/finality-provider/finality-provider/config" @@ -467,14 +469,14 @@ func runCommandAddFinalitySig(cmd *cobra.Command, args []string) error { // CommandEditFinalityDescription edits description of finality provider func CommandEditFinalityDescription() *cobra.Command { var cmd = &cobra.Command{ - Use: "edit-finality-provider [btc_pk]", + Use: "edit-finality-provider [eots_pk]", Aliases: []string{"efp"}, Short: "Edit finality provider data without resetting unchanged fields", - Long: "Edit the details of a finality provider using the specified BTC public key. " + - "\nThe provided [btc_pk] must correspond to the Babylon address controlled by the key specified in fpd.conf. " + + Long: "Edit the details of a finality provider using the specified EOTS public key. " + + "\nThe provided [eots_pk] must correspond to the Babylon address controlled by the key specified in fpd.conf. " + "\nIf one or more optional flags are passed (such as --moniker, --website, etc.), " + "the corresponding values are updated, while unchanged fields retain their current values from the Babylon Node.", - Example: fmt.Sprintf(`fpd edit-finality-provider [btc_pk] --daemon-address %s --moniker "new-moniker"`, defaultFpdDaemonAddress), + Example: fmt.Sprintf(`fpd edit-finality-provider [eots_pk] --daemon-address %s --moniker "new-moniker"`, defaultFpdDaemonAddress), Args: cobra.ExactArgs(1), RunE: runCommandEditFinalityDescription, }