Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EccLib initialization #3

Open
gbarkhatov opened this issue Jul 29, 2024 · 0 comments
Open

EccLib initialization #3

gbarkhatov opened this issue Jul 29, 2024 · 0 comments

Comments

@gbarkhatov
Copy link
Collaborator

  1. initBTCCurve should be added to Readme.md file
  2. Also, it might make sense to reraise this error on the isValidBitcoinAddress function instead of returning false as it's not that the address is invalid, but the setup is not properly initialized.

We can use getEccLib: https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/src/ecc_lib.js#L30 from bitcoinjs-lib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gbarkhatov