Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync params #15

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Sync params #15

merged 5 commits into from
Oct 16, 2024

Conversation

jrwbabylonlab
Copy link
Collaborator

image

gitferry
gitferry reviewed Oct 14, 2024
View reviewed changes
internal/services/service.go Outdated Show resolved Hide resolved
internal/db/model/params.go Show resolved Hide resolved
internal/services/global-params.go Outdated Show resolved Hide resolved
internal/clients/bbnclient/bbnclient.go Outdated Show resolved Hide resolved
internal/clients/bbnclient/bbnclient.go Show resolved Hide resolved
internal/clients/bbnclient/bbnclient.go Outdated Show resolved Hide resolved
gitferry
gitferry approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Parameter related comments can be resolved in future PRs as they are not a blocker for now

@jrwbabylonlab jrwbabylonlab merged commit cc5f0db into main Oct 16, 2024
9 of 11 checks passed
@jrwbabylonlab jrwbabylonlab deleted the sync-params branch October 16, 2024 00:07
@jeremy-babylonlabs jeremy-babylonlabs mentioned this pull request Oct 16, 2024
Closed
@jeremy-babylonlabs jeremy-babylonlabs mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitferry gitferry gitferry approved these changes

@gusin13 gusin13 Awaiting requested review from gusin13

@jeremy-babylonlabs jeremy-babylonlabs Awaiting requested review from jeremy-babylonlabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrwbabylonlab @gitferry