Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check global param in cache before db insertion #14

Open
jrwbabylonlab opened this issue Oct 14, 2024 · 2 comments
Open

Check global param in cache before db insertion #14

jrwbabylonlab opened this issue Oct 14, 2024 · 2 comments
Assignees

Comments

@jrwbabylonlab
Copy link
Collaborator

jrwbabylonlab commented Oct 14, 2024

In the indexer, we are constantly trying to save the global params per each polling iteration. what we should do instead are:

  1. Pull the existing global params into memory at service start up time
  2. For each polling result, check if already exist in memory
  3. Only if not exist, we insert.

This is a improvement ticket

@gusin13
Copy link
Collaborator

gusin13 commented Dec 1, 2024

@jrwbabylonlab if we pull from memory then how would indexer identify or update in case if params change in babylon?

@jrwbabylonlab
Copy link
Collaborator Author

@jrwbabylonlab if we pull from memory then how would indexer identify or update in case if params change in babylon?

@gusin13 the polling mechanism still continues, it just try to compare with the already saved result and see if there is changes.

Very low priority, don't think we actually need to do anything about it at this stage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants