Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-es schemas, types and fromBinary #4

Closed
gbarkhatov opened this issue Oct 21, 2024 · 2 comments
Closed

protoc-gen-es schemas, types and fromBinary #4

gbarkhatov opened this issue Oct 21, 2024 · 2 comments

Comments

@gbarkhatov
Copy link
Collaborator

Any reason to use this particular plugin? It generates a lot of duplicated data which will blow up our bundle size. From the another hand default plugin only generates schemas + types which can be used together with fromBinary method

Originally posted by @totraev in babylonlabs-io/simple-staking#237 (comment)

@gbarkhatov
Copy link
Collaborator Author

@totraev please add the details of your suggested approach. I.e.
Now we use stephenh-ts-proto, it grabs all the deps and builds the ts files. When we need something, we just import needed stuff and use it.

  • What changes do you suggest doing
  • What do we achieve if we go with that route
  • What our build process will look like
  • What is our usage of this library will look like, i.e. how do we consume the needed data/methods

@gbarkhatov
Copy link
Collaborator Author

Closed as we will go with #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant