Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server data filling rework and minor tweaks #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

furyzen
Copy link

@furyzen furyzen commented Feb 18, 2024

I've made some changes, primarily to fix the server data filling issue, caused by the different naming schemes between betacraft's server index and mojang's version's index.

Some notable changes:

  • updated gson to 2.10.1
  • populate server indexes before starting to modify the manifests, we can avoid looping through the entire index each edit like that
  • we fetch the latest server version compatible with the client (note: it include snapshots too)

Some notes:

  • gson seems to REALLY hate when we are using parallelized streams (random deserialization exceptions), so i've took the initiative to remove it
  • there are some hardcoded fixes to ensure subversions (ex: a1.2.3a and a1.2.3b) are correctly edited
  • i am not well familliar with kotlin, so it's probably very poorly implemented

i know this is not really useful for babric which is focused on b1.7.3 but it would be really cool if this could get reviewed and pushed, thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant