Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Janitor not working with clusterclasses (openstackclustername not clustername) #1

Open
qeqar opened this issue Nov 9, 2023 · 0 comments · May be fixed by #2
Open

Janitor not working with clusterclasses (openstackclustername not clustername) #1

qeqar opened this issue Nov 9, 2023 · 0 comments · May be fixed by #2

Comments

@qeqar
Copy link

qeqar commented Nov 9, 2023

The metadata.name is different to the cluster-name in ClusterClass clusters.
As it will use the OpenstackClusterTemplate name and add a UID

So in that case all checks failing as stated in the Read-me.

What i see is that both have

   labels:
      cluster.x-k8s.io/cluster-name: <cluster-name>

So if could change the code to pick that one, it would be usable on both.

Would be able to create a MR if needed.
@qeqar qeqar linked a pull request Nov 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

take cluster name from labels qeqar/cluster-api-janitor-openstack
1 participant
@qeqar