Not working if the game is completed in more than 3 steps

[connect-dips]

This quick and easy approach for the Tic Tac Toe game algorithm. One issue I have noticed is that the game works perfectly well if I win on the 3rd click. But, if I win on the 4th step it is not being counted and always return 'Game tied'.

This is because the below condition fails on the 4th click game win,

if(winningPosition && currentPlayerPositions === winningPosition){
     game.announceWinner();
}

Any fix identified?

Thanks.

[ayushgp]

@connect-dips Thanks for reporting the issue! The condition for checking win should be the following:

if((winningPosition & currentPlayerPositions) === winningPosition){
	game.announceWinner();
}

Note that its an & and not && as we need bitwise and not logical one.

[connect-dips]

@ayushgp this issue is reproducible on the demo here, http://tic-tac-toe-realtime.herokuapp.com/. The condition change was part of some workarounds I tried.

[ayushgp]

If you change the condition to the one I specified in my last comment, it is fixed. I updated the code on this repo on the ES5 branch but haven't updated it on heroku yet.

…

On Sep 6, 2017 6:07 PM, "DIPIN KUMAR KRISHNAN" ***@***.***> wrote: @ayushgp <https://github.com/ayushgp> this issue is reproducible on the demo here, http://tic-tac-toe-realtime.herokuapp.com/. The condition change was part of some workarounds I tried. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHn2b-Fm7JxCA8Jg6la3hb0_jbJJr7vOks5sfpHzgaJpZM4PNckp> .