Update for build scripts #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
It's a shame so much code has to be duplicated. We should probably extract the build script dance into a crate in the aya repo.
vadorovsky
requested changes
Nov 28, 2024
| ```console | ||
| cargo xtask run | ||
| ```shell | ||
| cargo run --config 'target."cfg(all())".runner="sudo -E"' |
There was a problem hiding this comment.
Let's keep the RUST_LOG=info thing in every example? We should also add it in the template. The reason why it was added in the first place was amount of confused people asking on Discord "but why I can't see the logs?" 😅
There was a problem hiding this comment.
Will do. I want to get clarify on aya-build before merging this pile of duplicated code :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a shame so much code has to be duplicated. We should probably
extract the build script dance into a crate in the aya repo.
Closes #176.