-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loading datasets saved via save_to_disk #1432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. @NanoCode012 ?
Looks like there are some issues with this change and the current integration tests we have, especially when loading remote datasets. |
I'll look through the docker tests that failed and add unittests for what's failing. |
I think this should fix the tests. The updates to main require |
One E2E test suite failed with this error:
This seems like it needs a re-run. The other E2E suite completed successfully |
yay~ |
* Support loading datasetes saved via save_to_disk * Adding comprehensive unittests * Fix dataset tests due to new hash changes
Description
Fixes
Uses
load_from_disk
when no data files are listed in a local directory dataset. This is to ensure datasets saved viasave_to_disk
are properly loaded.Motivation and Context
Datasets saved via
save_to_disk
currently can't be loaded without explicitly listing all files.#1430
How has this been tested?
Created a local dataset saved via
save_to_disk
and trained a model on it.Screenshots (if appropriate)
Types of changes
Small code change
Social Handles (Optional)
fozziethebeat on all the platforms