-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(test): Add tests for alpaca chatml prompt tokenizer #1088
Feat(test): Add tests for alpaca chatml prompt tokenizer #1088
Conversation
@NanoCode012 #112 Tagging you since your the creator of the issue, feel free to comment and feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello. Thank you for this PR. It's good to have more tests. We do have some small alpaca tests here, but they're for regular alpaca.
Your one seem to be more detailed for the chatml variant. Perhaps this class should be named TestAlpacaChatml
Also, I noticed some minor typos of alpacha
including the file name. Would it be possible to update them to alpaca
(without h
)?
Co-authored-by: NanoCode012 <[email protected]>
Thnx for the feedback! Agree with it and have updated, also fixed you comment about importing promptStyle |
@NanoCode012 let me know if there is anything more, or if it is good to go :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the reminder!
* draft for adding test for tokenizer * clean up * clean up * fix pre commit * fix pylint * Revert "fix pylint" This reverts commit cd2cda3. * add pylint exception for pytest fixture * update comments * Apply suggestions from code review Co-authored-by: NanoCode012 <[email protected]> * update spelling and import promptstyle * reaname, restrucure * clean up * add fmt:on --------- Co-authored-by: NanoCode012 <[email protected]>
In relation to #112, prf for adding test to the Alpaca prompt tokenizer.
For reference and testing I also compared with the code below.