Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load_from_disk for rl tpye training #2192

Open
5 tasks done
leeparkuky opened this issue Dec 15, 2024 · 1 comment
Open
5 tasks done

load_from_disk for rl tpye training #2192

leeparkuky opened this issue Dec 15, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@leeparkuky
Copy link

leeparkuky commented Dec 15, 2024 •
edited
Loading

⚠️ Please check that this feature request hasn't been suggested before.

  • I searched previous Ideas in Discussions didn't find any similar feature requests.
  • I searched previous Issues didn't find any similar feature requests.

🔖 Feature description

When the training is for rl, it should be able to read local dataset with load_from_disk.

✔️ Solution

In the line 118, you can find load_prepare_dpo_datasets and this should add a statement that read the local dataset with load_from_disk

❓ Alternatives

No response

📝 Additional Context

No response

Acknowledgements

  • My issue title is concise, descriptive, and in title casing.
  • I have searched the existing issues to make sure this feature has not been requested yet.
  • I have provided enough information for the maintainers to understand and evaluate this request.
@leeparkuky leeparkuky added the enhancement New feature or request label Dec 15, 2024
@leeparkuky
Copy link
Author

PR made:

#2193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leeparkuky