Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we use master branch or stable version? #2144

Closed
3 tasks done
fzyzcjy opened this issue Dec 7, 2024 · 5 comments
Closed
3 tasks done

Should we use master branch or stable version? #2144

fzyzcjy opened this issue Dec 7, 2024 · 5 comments

Comments

@fzyzcjy
Copy link

fzyzcjy commented Dec 7, 2024

What piece of documentation is affected?

Hi thanks for the library! Usually it is suggested to use stable version of a package (e.g. "release v0.5.2"), but it seems the README here uses the master branch, and the docker image is also mainly about latest master. Therefore, I wonder whether it is OK to use the master branch? i.e. will it be too unstable?

What part(s) of the article would you like to see updated?

(see above)

Additional Information

No response

Acknowledgements

  • My issue title is concise, descriptive, and in title casing.
  • I have searched the existing issues to make sure this feature has not been requested yet.
  • I have provided enough information for the maintainers to understand and evaluate this request.
@winglian
Copy link
Collaborator

winglian commented Dec 7, 2024

here's the diff of main vs the last release. There are mostly a lot of test fixes and updating to use some of the more recent upstream dependencies. We should be cutting a new release on Monday after I get some more testing updates done this weekend. Depending on what features you need most of the changes since 0.5.2 are likely to not affect you.

@fzyzcjy
Copy link
Author

fzyzcjy commented Dec 8, 2024

Thank you! I am mainly wondering a general question: should we use master or stable as a routine (not specific to this release)?

@djsaunde
Copy link
Contributor

djsaunde commented Dec 9, 2024

@fzyzcjy IMO, most users can use the latest stable version. If you want access to bleeding-edge features as they are added, then it might make sense to check out master, but as you noted, it may be less stable.

In short, in depends on how you intend to use the package!

@fzyzcjy
Copy link
Author

fzyzcjy commented Dec 9, 2024

Thank you! Then I guess the doc here can be updated to clone the latest stable instead of master.

image

@NanoCode012
Copy link
Collaborator

@fzyzcjy , thanks for that recommendation. We have an open PR to update that to install via pip for stable build instead #2137

@fzyzcjy fzyzcjy closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants