Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should tokenizer_legacy be default as false? #1955

Open
5 tasks done
tongyx361 opened this issue Oct 10, 2024 · 0 comments
Open
5 tasks done

Should tokenizer_legacy be default as false? #1955

tongyx361 opened this issue Oct 10, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request under review

Comments

@tongyx361
Copy link

⚠️ Please check that this feature request hasn't been suggested before.

  • I searched previous Ideas in Discussions didn't find any similar feature requests.
  • I searched previous Issues didn't find any similar feature requests.

🔖 Feature description

@NanoCode012 #401 (comment)
This was from a year ago. If I recall correctly, it was that the new behavior was not correct/created some issues esp for llama. It's very likely they fixed it and this should be reverted. If you would like, please create a new Issue on this, so we can track this better.

✔️ Solution

Default tokenizer_legacy as false?

❓ Alternatives

No response

📝 Additional Context

No response

Acknowledgements

  • My issue title is concise, descriptive, and in title casing.
  • I have searched the existing issues to make sure this feature has not been requested yet.
  • I have provided enough information for the maintainers to understand and evaluate this request.
@tongyx361 tongyx361 added the enhancement New feature or request label Oct 10, 2024
@bursteratom bursteratom self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request under review
Projects
None yet
Development

No branches or pull requests

3 participants