From 0c2a6303265f45117696e459396c843909a501a8 Mon Sep 17 00:00:00 2001 From: Wing Lian Date: Wed, 15 Nov 2023 12:52:32 -0500 Subject: [PATCH] multipack len should use max, not min (#863) --- src/axolotl/utils/samplers/multipack.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/axolotl/utils/samplers/multipack.py b/src/axolotl/utils/samplers/multipack.py index 4518939716..1acaa51b96 100644 --- a/src/axolotl/utils/samplers/multipack.py +++ b/src/axolotl/utils/samplers/multipack.py @@ -181,7 +181,7 @@ def _len_est(self): ) # shave off 1% + 1 for dealing with variance in packing from random sampler to sampler - return min( + return max( 1, ( world_size