-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_denoised adding spaces in output so half sentances is not coming in output #17
Comments
Hi kbrajwani, |
AM is not the correct sentence but my concern is not about correct prediction but i want to know why [D] is adding spaces in character. |
Which code are you running and on what dataset? |
Latest code of your repository with pretrained models. |
Tesing on iam dataset images. |
are all predictions like this or this particular one? |
No, only first and last line of prediction is come like that. |
Did you make any changes? |
Yes i made lots of change in your code, |
This file presents the methods the denoiser was trained. The data was modelled after the noise associated with the previous steps of our model. Judging from your example output "Torserane TVcom in Bankiner wo Finnnce", the noise seems quite different from our model and the words are not really recognisable. Most likely the pretrained denoiser wont work well. I found that the better the handwriting recognition, the better the denoiser. It might be beneficial for you to first improve the handwriting (i.e., focus on improving the output [AM]) then work on the denoiser. Please note that the output for our handwriting recognition is "Can't go lighting bonfites on this bus," and the denoiser only changed bonfites to bonfires. |
Did you edit any of the functions (denoiser.encode, generator.generate_sequences etc)? |
Same Issue With me, the final prediction has spaces and gives only half of the sentence like this, "This sentnce has an eror I have just changed |
Hi, I am having the same problem too. Does this require more than one GPU to do the job. If I am not wrong ctx_nlp = mx.gpu(3) command indicates that the variable is being assigned to the 4th GPU in case there are 4 GPUs. If the line is left as such it gives out an error telling that the number should be 1 less than the number of GPU devices. Since I have only one, I had assigned it as ctx_nlp = mx.gpu(0). But that in turn cuts out half the sentence adding a space between the alphabets as already mentioned by a few here. Not sure whether it is exactly a GPU problem. Was wondering whether this can be run on a CPU rather !! Any help is appreciated!! |
@raghav-menon @devbaseh |
Thank you for the quick reply. I am using the IAM dataset. I have tried using both CPU and GPU and the problem persists. The demoing output only gives partial sentences with a space in between. The system I am using is AWS with 64 GB of RAM and a Tesla K80 attached. |
Would be grateful if you could advise me on how to solve it!! Thanks |
I'll try to have a look this weekend, have you tried retraining from the denoising notebook? |
Thanks Thomas. I have only used the trained model provided and ran the code. Have not tried retraining!! |
If anybody executed it on Google colab ,please sharethe edited iam_dataset.py it with me , [email protected] |
Same issue here, didn't modify any code besides changing gpu from 3 to 0: "This sentnce has an eror |
i'm facing this error ... Can u help me on this ?? i didnt find the problem
…On Sun, Oct 4, 2020 at 3:36 AM yangyingxiang ***@***.***> wrote:
Same issue here, didn't modify any code besides changing gpu from 3 to 0:
"This sentnce has an eror
Choice
T h i s s e n t e n c e "
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMR2YQOOWDI4QEGW44MPWYTSI6KNHANCNFSM4JEQEEXQ>
.
|
@jonomon @ThomasDelteil Is there any update on the space issue we are getting in denoiser?? An update from you guys will make my day. Thanks for this wonderful repository. 👍 |
@mahin003 @yangyingxiang @raghav-menon @devbaseh @kbrajwani I had initiated a merge here I hope, this solves your issues as well. I just got it solved in my code. :) |
[AM] Torserane TVcom in Bankiner wo Finnnce
[D ] T o r e v e n g e T o m i n B a
see am is full sentance but [D ] is cutting down sentance. tell me where can i change the code to get correct output.
The text was updated successfully, but these errors were encountered: