Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming a module sagemaker confuses pylint #881

Open
thvasilo opened this issue Jun 17, 2024 · 3 comments
Open

Naming a module sagemaker confuses pylint #881

thvasilo opened this issue Jun 17, 2024 · 3 comments
Labels
0.4.1 0.5 bug Something isn't working

Comments

@thvasilo
Copy link
Contributor

Because we include a graphstorm.sagemaker module, we can false positives in pylint such as

************* Module python.graphstorm.sagemaker.sagemaker_partition
[2024-06-17T22:04:35.164Z] python/graphstorm/sagemaker/sagemaker_partition.py:33:0: C0411: third party import "from joblib import Parallel, delayed" should be placed before "import sagemaker" (wrong-import-order)`

We should rename our graphstorm.sagemaker module to something like graphstorm.gs_sagemaker to avoid such issues and ambivalence about whether we are importing the sagemaker lib or local module.

@classicsong
Copy link
Contributor

Can we close it?

@thvasilo
Copy link
Contributor Author

We can either close as won't fix, or rename the module to something like gsf_sagemaker which should get rid of the error. This should be easy enough to do using an IDE.

@thvasilo
Copy link
Contributor Author

Another paper cut /UX issue is the naming of the graphstorm/sagemaker directory.
If we clone graphstorm and do

cd graphstorm
pip install .
python
>>> import sagemaker

it will try to import the local graphstorm/sagemaker directory which is not our intent here, what we want is to import the sagemaker sdk.

@thvasilo thvasilo reopened this Dec 12, 2024
@thvasilo thvasilo added bug Something isn't working 0.5 0.4.1 labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.4.1 0.5 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants