From f07cbd534619571e5c33851280c68fca4873ce5b Mon Sep 17 00:00:00 2001 From: Xiang Song Date: Fri, 7 Jun 2024 11:22:13 -0700 Subject: [PATCH] Fix comments --- .github/workflow_scripts/e2e_mgpu_check.sh | 2 +- python/graphstorm/dataloading/dataloading.py | 6 +++--- tests/end2end-tests/data_gen/movielens_multi_task.json | 6 +++--- training_scripts/gsgnn_mt/ml_nc_ec_er_lp.yaml | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflow_scripts/e2e_mgpu_check.sh b/.github/workflow_scripts/e2e_mgpu_check.sh index 35ea1b4654..e6bc38d261 100644 --- a/.github/workflow_scripts/e2e_mgpu_check.sh +++ b/.github/workflow_scripts/e2e_mgpu_check.sh @@ -1,7 +1,7 @@ # Move to parent directory cd ../../ -pip install --no-cache-dir --extra-index-url https://pypi.nvidia.com pylibwholegraph-cu11 +pip install --no-cache-dir --extra-index-url https://pypi.nvidia.com pylibwholegraph-cu11==24.4.0 set -ex diff --git a/python/graphstorm/dataloading/dataloading.py b/python/graphstorm/dataloading/dataloading.py index ff47600c04..1020529857 100644 --- a/python/graphstorm/dataloading/dataloading.py +++ b/python/graphstorm/dataloading/dataloading.py @@ -1280,10 +1280,10 @@ def __next__(self): return cur_iter, self._neg_sample_type def __len__(self): - num_samples = 0 + num_iters = 0 for _, test_size in self._fixed_test_size.items(): - num_samples += math.ceil(test_size / self._batch_size) - return num_samples + num_iters += math.ceil(test_size / self._batch_size) + return num_iters @property def fanout(self): diff --git a/tests/end2end-tests/data_gen/movielens_multi_task.json b/tests/end2end-tests/data_gen/movielens_multi_task.json index 4d79b8b2b3..5fa1f4d865 100644 --- a/tests/end2end-tests/data_gen/movielens_multi_task.json +++ b/tests/end2end-tests/data_gen/movielens_multi_task.json @@ -74,9 +74,9 @@ { "task_type": "link_prediction", "split_pct": [0.1, 0.1, 0.1], - "mask_field_names": ["train_mask_field_l", - "val_mask_field_l", - "test_mask_field_l"] + "mask_field_names": ["train_mask_field_lp", + "val_mask_field_lp", + "test_mask_field_lp"] } ] } diff --git a/training_scripts/gsgnn_mt/ml_nc_ec_er_lp.yaml b/training_scripts/gsgnn_mt/ml_nc_ec_er_lp.yaml index fe2ff2b1f6..8b13e18d6c 100644 --- a/training_scripts/gsgnn_mt/ml_nc_ec_er_lp.yaml +++ b/training_scripts/gsgnn_mt/ml_nc_ec_er_lp.yaml @@ -98,7 +98,7 @@ gsf: batch_size: 128 # will overwrite the global batch_size mask_fields: - "train_mask_field_lp" - - "val_mask_field_l" # empty means there is no validation mask + - "val_mask_field_lp" # empty means there is no validation mask - null # empty means there is no test mask task_weight: 1.0 - reconstruct_node_feat: