Enhancing Schema Version Management with Tag-Based Lookup Feature #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will resubmit with necessary test coverage included. |
YangSan0622
requested review from
YangSan0622
and removed request for
YangSan0622
|
All of the integration tests are failing, and I do not think I am able to rerun them, do you mind re-create this PR? |
|
Sure. Will do by this end of this week.
From: George Yang ***@***.***>
Reply-To: awslabs/aws-glue-schema-registry ***@***.***>
Date: Wednesday, July 10, 2024 at 11:36 AM
To: awslabs/aws-glue-schema-registry ***@***.***>
Cc: "Shrivastava, Vivek" ***@***.***>, Author ***@***.***>
Subject: Re: [awslabs/aws-glue-schema-registry] Enhancing Schema Version Management with Tag-Based Lookup Feature (PR #318)
All of the integration tests are failing, and I do not think I am able to rerun them, do you mind re-create this PR?
—
Reply to this email directly, view it on GitHub<#318 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AU5WTBRY5S375ISSRFRC2P3ZLVIHDAVCNFSM6AAAAABKVFOET6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQHA2DOMZTHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: None
Description of changes:
Introducing tag-based lookup for schema versions to address 'poison pill' issues. Previously, recreating a schema or its version post-deletion resulted in altered UUIDs for schema versions, leading to 'poison pill' records in MSK due to deserialization failures. This update enables schema version lookup via metadata keys instead of UUIDs. When tag-based lookup is activated in the configuration, the system performs a metadata search for matching tags, subsequently using the appropriate schema version. This enhancement reduces the occurrence of 'poison pill' records by enabling schema lookup in scenarios where the schema is recreated post-deletion or redeployed via version control as part of disaster recovery processes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.