Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AwsCommonRuntimeKit potentially needs a privacy manifest #251

Closed
phantumcode opened this issue Apr 10, 2024 · 2 comments
Closed

AwsCommonRuntimeKit potentially needs a privacy manifest #251

phantumcode opened this issue Apr 10, 2024 · 2 comments
Labels
bug This issue is a bug.

Comments

@phantumcode
Copy link

Describe the bug

Issue originally created in the amplify-swift repo by @rowanlsnapper aws-amplify/amplify-swift#3603

I'm working through some privacy manifest issues with an app that I'm working on, and the last remaining required reason API warning that I'm still dealing with is "file timestamps" (https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api#4278393).

I'm confident that the app itself is not directly using any of the mentioned file timestamp APIs, and I've worked through the dependencies to see which of them could be using these without proper privacy manifest declarations. I notice that AwsCommonRuntimeKit is using fstat(:,:) in a couple of C source files, and it looks like the module doesn't declare this in a privacy manifest.

Could this please be investigated and actioned if necessary.

Expected Behavior

App Store Connect does not send an email advising undeclared required reason API usage, app passes validation.

Current Behavior

Unknown

Reproduction Steps

  1. Create an app that includes amplify-swift using SPM (in my case am linking Amplify, AWSPluginsCore, and AWSCognitoAuthPlugin to my app target).
  2. Submit app to the App Store for RR API validation (can be triggered by assigning a build to a TestFlight external tester group).
  3. Observe App Store Connect sends an email advising undeclared required reason API usage.

Possible Solution

No response

Additional Information/Context

No response

aws-crt-swift version used

0.26.1

Compiler and Version used

Swift 5.7

Operating System and version

iOS

@phantumcode phantumcode added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 10, 2024
@phantumcode phantumcode changed the title AwsCommonRuntimeKit potentially needs a privacy manifest(short issue description) AwsCommonRuntimeKit potentially needs a privacy manifest Apr 10, 2024
@sichanyoo
Copy link
Contributor

Thank you for transferring the ticket @phantumcode. And thank you for submitting the original ticket @rowanlsnapper.

We already have a ticket that tracks this in aws-sdk-swift: awslabs/aws-sdk-swift#1191.

I'll pick up this task now; all updates / PRs will be posted to the ticket in our aws-sdk-swift repo.

Closing the ticket as it's tracked in awslabs/aws-sdk-swift#1191.

@sichanyoo sichanyoo removed the needs-triage This issue or PR still needs to be triaged. label Apr 16, 2024
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants