Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrating-from-cas page need to be updated #7394

Open
rshiva777 opened this issue Nov 16, 2024 · 3 comments
Open

migrating-from-cas page need to be updated #7394

rshiva777 opened this issue Nov 16, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation needs-triage Issues that need to be triaged

Comments

@rshiva777
Copy link

rshiva777 commented Nov 16, 2024

Description

How can the docs be improved?

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Karpenter documentation doesnt have the steps provided to create an SQS in the migrate from cas page below, but in helm installation step it is passing "settings.interruptionQueue=${CLUSTER_NAME}" parameter due to which installation is failing showing that there is no queue found

Document link: https://karpenter.sh/preview/getting-started/migrating-from-cas/

Reference command:

helm template karpenter oci://public.ecr.aws/karpenter/karpenter --version "${KARPENTER_VERSION}" --namespace "${KARPENTER_NAMESPACE}" \
    --set "settings.clusterName=${CLUSTER_NAME}" \
    --set "settings.interruptionQueue=${CLUSTER_NAME}" \
    --set "serviceAccount.annotations.eks\.amazonaws\.com/role-arn=arn:${AWS_PARTITION}:iam::${AWS_ACCOUNT_ID}:role/KarpenterControllerRole-${CLUSTER_NAME}" \
    --set controller.resources.requests.cpu=1 \
    --set controller.resources.requests.memory=1Gi \
    --set controller.resources.limits.cpu=1 \
    --set controller.resources.limits.memory=1Gi > karpenter.yaml
@rshiva777 rshiva777 added documentation Improvements or additions to documentation needs-triage Issues that need to be triaged labels Nov 16, 2024
@mariuskimmina
Copy link

mariuskimmina commented Nov 18, 2024

Seems like this now got fixed in #7273

Edit: Actually nvm, that only added the queue to the command

@mozammil89
Copy link

This PR should fix this issue. Awaiting approval...

#7343

@rafael-debug
Copy link

Sqs documents is very important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation needs-triage Issues that need to be triaged
Projects
None yet
Development

No branches or pull requests

4 participants