Add Nutanix CCM ignore node IPs list #9068
Conversation
|
Hi @adiantum. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eks-distro-bot
added
the
size/XXL
- fix kube-vip validation - fix kube-vip add to ignore node list - add unit-test
|
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9068 +/- ##
==========================================
+ Coverage 72.37% 72.41% +0.04%
==========================================
Files 578 578
Lines 45451 45590 +139
==========================================
+ Hits 32897 33016 +119
- Misses 10824 10838 +14
- Partials 1730 1736 +6 ☔ View full report in Codecov by Sentry. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@panktishah26: #9068 failed to apply on top of branch "release-0.21": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
Add kube-vip and optional list of ip addresses to CCM node ip addresses ignore list.
Required to fix bug with LB ip pool ranges and kube vip interception with node ip addresses.
Testing (if applicable):
CCM config generated as expected:
Documentation added/planned (if applicable):
Description of 'ccmExcludeNodeIPs' field of NutanixDatacenterConfig spec will be added
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.