From 23bf9b528dfdc7d8030d5a3a6cb802bff1961d77 Mon Sep 17 00:00:00 2001 From: Abhinav Pandey Date: Tue, 10 Dec 2024 15:29:26 -0800 Subject: [PATCH] Fixing jgw typos (#4118) Co-authored-by: Abhinav Pandey --- projects/kubernetes-sigs/image-builder/README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/projects/kubernetes-sigs/image-builder/README.md b/projects/kubernetes-sigs/image-builder/README.md index 6183a5b080..49d547e45f 100644 --- a/projects/kubernetes-sigs/image-builder/README.md +++ b/projects/kubernetes-sigs/image-builder/README.md @@ -38,9 +38,9 @@ EKS-A CLI project uses these images as the node image when constructing workload 1. Run `git format-patch `, where `` is the last upstream commit on that tag. Move the generated patches from under the upstream fork to the projects/kubernetes-sigs/image-builder/patches/ folder in this repo. 1. Update the `GIT_TAG` file to have the new desired version based on the upstream release tags. 1. Compare the old tag to the new, looking specifically for Makefile changes. If any of the make targets used in projects/kubernetes-sigs/image-builder/Makefile to call upstream make changed, make those appropriate changes. -1. Update the version at the top of this Readme. -1. Ensure [REQUIRED_DEPENDENCY_VERSIONS.yaml](./REQUIRED_DEPENDENCY_VERSIONS.yaml) is updated, by running `make update-dependency-versions`, with the newly required python/ansible/packer/plugins versions. Uses these versions to update the [builder-base](https://github.com/aws/eks-distro-build-tooling/blob/main/builder-base/versions.yaml) - which will need to be done before presubmits will pass. Before merging, also update the ECImageBuilder recipe in the build account and generate a new AMI we use for raw image builds. +1. Update the version at the top of this README. +1. Ensure [REQUIRED_DEPENDENCY_VERSIONS.yaml](./REQUIRED_DEPENDENCY_VERSIONS.yaml) is updated, by running `make update-dependency-versions`, with the newly required python/ansible/packer/plugins versions. Use these versions to update the [builder-base](https://github.com/aws/eks-distro-build-tooling/blob/main/builder-base/versions.yaml) + which will need to be done before presubmits will pass. Before merging, also update the EC2ImageBuilder recipe in the build account and generate a new AMI we use for raw image builds. 1. Ensure that the RHEL 8 and RHEL 9 semvers and the `kmod-megaraid` RPMs in the Makefile are updated. This will require uploading the corresponding ISO and QCOW2 images and RPM to the `redhat-iso-pdx` S3 bucket. 1. Monitor node image builds and e2e tests as updates to this project can potentially break cluster create and update process.