From 3a73f6ea3036b7bc9d08e93d29b62dacdf5cf7ee Mon Sep 17 00:00:00 2001 From: Austin Ely Date: Thu, 31 Aug 2023 12:44:29 -0400 Subject: [PATCH] chore: make app delete default to no in confirmation prompt (#5267) Quick fix to address #5258. We shouldn't default to "yes" on app delete confirmation, as that makes it easy to destroy apps with an errant keypress. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License. --- internal/pkg/cli/app_delete.go | 1 - 1 file changed, 1 deletion(-) diff --git a/internal/pkg/cli/app_delete.go b/internal/pkg/cli/app_delete.go index 2796c998945..5f87ea4bf1e 100644 --- a/internal/pkg/cli/app_delete.go +++ b/internal/pkg/cli/app_delete.go @@ -173,7 +173,6 @@ func (o *deleteAppOpts) Ask() error { manualConfirm, err := o.prompt.Confirm( fmt.Sprintf(fmtDeleteAppConfirmPrompt, o.name), deleteAppConfirmHelp, - prompt.WithTrueDefault(), prompt.WithConfirmFinalMessage()) if err != nil { return fmt.Errorf("confirm app deletion: %w", err)