Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export for resolveManualSegmentParams to AWSXRay #628

Merged
merged 8 commits into from
Jan 29, 2024

Conversation

jasonterando
Copy link
Contributor

This PR adds an export for resolveManualSegmentParams to AWSRay. This is to allow access to that function from plugins/extensions published in the sdk_contrib

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jasonterando jasonterando requested a review from a team as a code owner January 24, 2024 22:42
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6fb649) 83.49% compared to head (51ea81e) 83.49%.

❗ Current head 51ea81e differs from pull request most recent head b778942. Consider uploading reports for the commit b778942 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #628   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files          37       37           
  Lines        1805     1805           
=======================================
  Hits         1507     1507           
  Misses        298      298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jj22ee
Copy link
Contributor

jj22ee commented Jan 29, 2024

Updated a comment.
Thanks, LGTM

@jj22ee jj22ee merged commit 1d50325 into aws:master Jan 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants