Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging an exception instead of / and a raise pollutes the log with extra traceback. #615

Open
ShubhamChaturvedi7 opened this issue Sep 21, 2023 · 0 comments

Comments

@ShubhamChaturvedi7
Copy link
Contributor

Problem:

In many places in the SDK codebase, there are exception logging using the _LOGGER.exception. This logs the traceback of the exception. The encountered exception might then be bubbled up to the caller, or to the exit call which then again logs this exception. This causes duplicate logging at best, and confusion at worst since the exception message/type can be different.

Solution:

Clean up the logging, and use raise over logging the exception wherever possible.

Ref #566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant