Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CryptoMaterialsCache return stats #125

Open
mayitbeegh opened this issue Oct 3, 2019 · 1 comment
Open

Make CryptoMaterialsCache return stats #125

mayitbeegh opened this issue Oct 3, 2019 · 1 comment

Comments

@mayitbeegh
Copy link

mayitbeegh commented Oct 3, 2019

I'd like to collect some metrics on caching for performance optimization and CryptoMaterialsCache currently doesn't provide a way to collect stats such as size, hit, and miss. Could the CryptoMaterialsCache class be wired up to provide something similar to Caffeine or Guava cache such as size() and snapshot()?

Here are some examples:
https://github.com/ben-manes/caffeine/blob/master/caffeine/src/main/java/com/github/benmanes/caffeine/cache/stats/CacheStats.java#L60
https://github.com/google/guava/blob/master/guava/src/com/google/common/cache/LocalCache.java#L4913
https://github.com/google/guava/blob/master/guava/src/com/google/common/cache/AbstractCache.java#L239

@lavaleri
Copy link
Contributor

lavaleri commented Oct 4, 2019

Hi! Thank you for reaching out.

Yes, this is a useful feature that we want to implement, though we do not currently have a timeline for when it will be available.

We’ll keep your issue open and provide updates here when we have more. Thanks again, and if there’s any other information about the use case that you want to share, we’ll take the feedback as we work on the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants