Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add keyrings #102

Open
13 of 15 tasks
mattsb42-aws opened this issue Apr 5, 2019 · 0 comments
Open
13 of 15 tasks

add keyrings #102

mattsb42-aws opened this issue Apr 5, 2019 · 0 comments
Assignees
@WesleyRosenblum
Labels
doc_update_required enhancement

Comments

@mattsb42-aws
Copy link
Member

mattsb42-aws commented Apr 5, 2019 •
edited by WesleyRosenblum
Loading

Starting with the AWS Encryption SDK for C, we moved from master keys/providers to keyrings as a configuration/framework primitive. We need to add corresponding keyrings to this client as well.

See #150 for a discussion on the evolution of the API as we transition to Keyrings
See #153 for a discussion on the ergonomics of Keyrings

All keyring development PRs should be made to the keyring branch.
@ttjsu-aws ttjsu-aws mentioned this issue May 24, 2019
Closed
15 tasks
@WesleyRosenblum WesleyRosenblum self-assigned this Oct 17, 2019
WesleyRosenblum added a commit that referenced this issue Oct 25, 2019
@WesleyRosenblum
Create keyring trace and add to encryption and decryption materials.
0da3c83 
*Issue #, if available:* #102

*Description of changes:*

Creating a keyring trace and adding to encryption and decryption materials to allow for auditing actions a keyring has taken on encryption materials.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

# Check any applicable:
- [ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.
@WesleyRosenblum WesleyRosenblum mentioned this issue Oct 25, 2019
Merged
1 task
WesleyRosenblum added a commit that referenced this issue Oct 30, 2019
@WesleyRosenblum
Create keyring trace and add to encryption and decryption materials. (#…
9307933 
…134)

* Create keyring trace and add to encryption and decryption materials.

*Issue #, if available:* #102

*Description of changes:*

Creating a keyring trace and adding to encryption and decryption materials to allow for auditing actions a keyring has taken on encryption materials.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

# Check any applicable:
- [ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.
WesleyRosenblum added a commit that referenced this issue Nov 1, 2019
@WesleyRosenblum
Refactor JceMasterKey to extract logic to be shared by raw keyrings.
93f9691 
*Issue #, if available:* #102

*Description of changes:*

In anticipation of the RawAesKeyring and RawRsaKeyring needing logic currently embedded in the JceMasterKey, this change extracts that logic into the JceKeyCipher class so it may be shared.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- [ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.
@WesleyRosenblum WesleyRosenblum mentioned this issue Nov 1, 2019
Merged
1 task
WesleyRosenblum added a commit that referenced this issue Nov 7, 2019
@WesleyRosenblum
Refactor JceMasterKey to extract logic to be shared by raw keyrings.
c7fdb9e 
*Issue #, if available:* #102

*Description of changes:*

In anticipation of the RawAesKeyring and RawRsaKeyring needing logic currently embedded in the JceMasterKey, this change extracts that logic into the JceKeyCipher class so it may be shared.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- [ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.
WesleyRosenblum added a commit that referenced this issue Nov 7, 2019
@WesleyRosenblum
Defining Keyring interface and implementing RawKeyring.
4bbe029 
*Issue #, if available:* #102

*Description of changes:*

This change defines the Keyring interface and an implementation of a RawKeyring which supports both AES and RSA.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

# Check any applicable:
- [ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.
WesleyRosenblum added a commit that referenced this issue Nov 8, 2019
@WesleyRosenblum
Refactor JceMasterKey to extract logic to be shared by raw keyrings. (#…
4fdc309 
…139)

* Refactor JceMasterKey to extract logic to be shared by raw keyrings.

*Issue #, if available:* #102

*Description of changes:*

In anticipation of the RawAesKeyring and RawRsaKeyring needing logic currently embedded in the JceMasterKey, this change extracts that logic into the JceKeyCipher class so it may be shared.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- [ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.
WesleyRosenblum added a commit that referenced this issue Nov 11, 2019
@WesleyRosenblum
Defining Keyring interface, RawAesKeyring and RawRsaKeyring.
c2bcffe 
*Issue #, if available:* #102

*Description of changes:*

This change defines the Keyring interface, RawAesKeyring and RawRsaKeyring.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

# Check any applicable:
- [ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.
@WesleyRosenblum WesleyRosenblum mentioned this issue Nov 11, 2019
Merged
1 task
WesleyRosenblum added a commit that referenced this issue Nov 21, 2019
@WesleyRosenblum
Defining Keyring interface, RawAesKeyring and RawRsaKeyring. (#142)
36958b8 
* Defining Keyring interface, RawAesKeyring and RawRsaKeyring.

*Issue #, if available:* #102

*Description of changes:*

This change defines the Keyring interface, RawAesKeyring and RawRsaKeyring.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

# Check any applicable:
- [ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

* Moving factory methods to StandardKeyrings and correcting RawAes trace.

* Adding additional tests for RawAesKeyring and RawRsaKeyring

* Creating separate Encryption/Decryption materials for Keyring usage

To maintain backward compatibility with MasterKey/MasterKeyProviders,
new EncryptionMaterials and DecryptionMaterials classes are defined for
use in Keyrings, so they can include names inline with the spec and
additional validation. This change also adds test dependencies for
JUnit5.

* Minor formatting fixes

* Fixing comments and migrating KeyringTraceTest to JUnit5

* Renaming algorithm to algorithmSuite

* Making optional materials properties throw exceptions if not populated.

* Using Objects.requireNonNull and renaming builder methods
WesleyRosenblum added a commit that referenced this issue Nov 22, 2019
@WesleyRosenblum
*Issue #, if available:* #102
1bef9f5 
*Description of changes:*

Defining the KMS Keyring.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

# Check any applicable:
- [ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.
This was referenced Jan 13, 2020
Closed
Merged
WesleyRosenblum added a commit that referenced this issue Apr 7, 2020
@WesleyRosenblum @SalusaSecondus
Merge head of master into keyring (#169)
ebda774 
* Add a basic example for encrypting and decrypting with a KMS CMK (#136)

* *Issue #, if available:* #108

*Description of changes:*

Add a basic example for encrypting and decrypting with a KMS CMK.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

# Check any applicable:
- [ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

* Add test and Maven plugin to include examples directory as test source

* Update docs in prep for 1.6.1 (#133)

* Update docs in prep for 1.6.1
* Actually bump version for release

* Fix for new versions of gpg

* Refactor JceMasterKey to extract logic to be shared by raw keyrings. (#139)

* Refactor JceMasterKey to extract logic to be shared by raw keyrings.

*Issue #, if available:* #102

*Description of changes:*

In anticipation of the RawAesKeyring and RawRsaKeyring needing logic currently embedded in the JceMasterKey, this change extracts that logic into the JceKeyCipher class so it may be shared.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- [ ] Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

* fix: The final frame can not be larger than the Frame Length (#166)

* Add validation to ensure the length of the final frame in the final
frame header does not exceed the frame size specified in the message
header.

* Validate that frame length is positive for framed data

* Reverting removal of variable frame length code

* Reverting removal of variable frame length code

* Fix spacing after if

Co-authored-by: SalusaSecondus <[email protected]>
Co-authored-by: Greg Rubin <[email protected]>
@WesleyRosenblum WesleyRosenblum mentioned this issue Apr 13, 2020
Merged
1 task
This was referenced Dec 9, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WesleyRosenblum WesleyRosenblum

Labels
doc_update_required enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsb42-aws @WesleyRosenblum