fix(.NET): Improve Collection of Errors string #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
changed the title
Patch files updated via: ``` gmake polymorph_dotnet DAFNY_VERSION=4.9.0 POLYMORPH_OPTIONS=--update-patch-files |& tee poly.log |& less -r +F ```
texastony
force-pushed
the
tony/fix-collectionOfErrors
branch
from
0e05ae6 to
7705c2c
Compare
| public CollectionOfErrors(string message) : base(message) { this.list = new System.Collections.Generic.List<Exception>(); } | ||
| public CollectionOfErrors() : base("CollectionOfErrors") { this.list = new System.Collections.Generic.List<Exception>(); } | ||
|
|
||
| private static string ListAsString(List<Exception> list) |
There was a problem hiding this comment.
Non blocking suggestion to maintain consistency in this class:
Suggested change
| private static string ListAsString(List<Exception> list) | |
| private static string ListAsString(System.Collections.Generic.List<Exception> list) |
And remove the import and update dafny patch
There was a problem hiding this comment.
I am OK with this style divergence.
This is Beneration.
Ideally, we would go back and refactor Smithy-Dafny such that it always generates this.
I am not sure if/when we will do that,
as it may happen as part of other Smithy-Dafny feature development.
But this logic was written by a human;
it was not machine generated.
It is acceptable for it to appear as such;
it may even be preferred,
as it helps clarify what was benerated from what was generated.
rishav-karanjit
approved these changes
Jan 2, 2025
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Collection of Errors is a frustrating error because it requires customer action
to completely serialize it into logs.
We can make a simple fix in .NET to improve the CX,
by always serializing the list into the Collection Of Error's
message.
We concatenate the given error message with
a serialization of all the nested errors.
See similar PR for MPL-Java: aws/aws-cryptographic-material-providers-library@9e195a1
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.