Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Move hardcoded labels to the i18n file #263

Open
mtfranchetto opened this issue Aug 18, 2022 · 0 comments
Open

Move hardcoded labels to the i18n file #263

mtfranchetto opened this issue Aug 18, 2022 · 0 comments
Labels
tech-debt Legacy issues or new tools adoption

Comments

@mtfranchetto
Copy link
Contributor

Description

With the introduction of i18n (with #175) we have the ability of internationalize PCluster Manager. However, the codebase is scattered with hardcoded labels that cannot be replaced at runtime with the language chosen by the user.
We should find all the places where labels are hardcoded, and move them to the strings.json file.

Look at #175 for an example on how to do it.
@mtfranchetto mtfranchetto added the tech-debt Legacy issues or new tools adoption label Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
tech-debt Legacy issues or new tools adoption
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mtfranchetto