拡張機能: 認証処理の修正 #645
Merged
拡張機能: 認証処理の修正 #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadabee
commented
Sep 2, 2024
Comment on lines
+73
to
+81
| {hasAuthenticated ? ( | ||
| <>{props.children}</> | ||
| ) : settings.enabledSamlAuth ? ( | ||
| <div className="flex justify-center mt-3"> | ||
| <Button onClick={() => signIn()}>ログイン画面へ</Button> | ||
| </div> | ||
| ) : ( | ||
| <Authenticator hideSignUp={!settings.enabledSelfSignUp}>{props.children}</Authenticator> | ||
| )} |
There was a problem hiding this comment.
SAML認証とUserPool認証で、認証済み画面を表示するロジックを共通化しました。
こちらは、UserPoolで認証を行った際に、認証済みでもAuthenticatorのChildrenが表示されない問題を回避する目的です。
恐らく、Authenticatorの設定項目を非同期で取得して設定している関係で、Authenticatorが認証ステータスを正しく取得できないことに起因する問題と思われます。
（SAML認証でも同様の問題があったのですが、UserPoolでもこの問題が発生することがわかり、共通化しました）
tbrand
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.