[拡張機能] Response形式変更に伴う修正 #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadabee
commented
Aug 7, 2024
Comment on lines
+37
to
+43
| updateMessageContent: ( | ||
| state, | ||
| action: PayloadAction<TabId & { index: number; content: string }> | ||
| ) => { | ||
| setInitialStateIfNeeded(state, action.payload.tabId); | ||
| state[action.payload.tabId].messages[action.payload.index].content = action.payload.content; | ||
| }, |
There was a problem hiding this comment.
こちらはパフォーマンス向上のための修正です。
本件には関係ないのですが、合わせて実施しました。
Comment on lines
+30
to
+36
| middleware: [ | ||
| flip(), | ||
| shift(), | ||
| autoPlacement({ | ||
| allowedPlacements: ['top', 'top-start', 'top-end', 'bottom', 'bottom-start', 'bottom-end'], | ||
| }), | ||
| ], |
There was a problem hiding this comment.
画面上の文言と拡張機能のフローティングが被る時があったので、その修正も合わせて実施しました。
tbrand
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
「続きを出力」でResponse形式が変わったので、その修正です。
（「続きを出力」には対応していません）
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.