Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable S3 Versioning (primarily for Securityhub finding S3.14) #12

Closed
xnick123 opened this issue Aug 5, 2024 · 1 comment
Closed

Enable S3 Versioning (primarily for Securityhub finding S3.14) #12

xnick123 opened this issue Aug 5, 2024 · 1 comment

Comments

@xnick123
Copy link
Contributor

xnick123 commented Aug 5, 2024

Hi,

i will contribute a small change to enable versioning, to resolve AWS Securityhub finding:
_07/08/2024 corrected from _ [S3.10] S3 general purpose buckets with versioning enabled should have Lifecycle configurations
to [S3.14] [S3 general purpose buckets should have versioning enabled](https://docs.aws.amazon.com/securityhub/latest/userguide/s3-controls.html#s3-14)

If interested, i'll add some more, like logging for the same reason.

We have a POC in our company and are glad you shared this solution!

Best Regards,
Nick

@xnick123 xnick123 changed the title Enable S3 Versioning (primarily for Securityhub finding S3.10) Enable S3 Versioning (primarily for Securityhub finding S3.14) Aug 7, 2024
@steffeng
Copy link
Member

Thanks @xnick123, for the feedback and the contribution. Based on your feedback, in PR #18 we implemented automated AWS CloudFormation Guard checks for the Security Pillar on Pull Requests. We did fix most checks and raised the security bar. However, we don't want to make a decision for customers' versioning or a retention policies. Customers will have to make this decision triggered by AWS Security Hub on their own if they specified this rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants