Added new badge and message for AI kit #8110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanksdesign
previously approved these changes
Dec 10, 2024
dindjarinjs
reviewed
Dec 10, 2024
dindjarinjs
reviewed
Dec 10, 2024
dindjarinjs
reviewed
Dec 10, 2024
dindjarinjs
reviewed
Dec 10, 2024
dindjarinjs
reviewed
Dec 10, 2024
src/components/Banner/Banner.tsx
Outdated
| } | ||
|
|
||
| export const Banner: React.FC<BannerProps> = ({ | ||
| url = '/react/ai/set-up-ai/' |
There was a problem hiding this comment.
Probably don't need this prop since the rest of the banner content is hardcoded, right? Might as well just put it directly on the button
There was a problem hiding this comment.
OK I'll make it a constant variable URL
dindjarinjs
reviewed
Dec 10, 2024
src/components/Banner/Banner.tsx
Outdated
| href={url} | ||
| size="small" | ||
| gap="small" | ||
| target="_blank" |
There was a problem hiding this comment.
Why open a new window on the same site?
dindjarinjs
reviewed
Dec 10, 2024
src/components/Layout/Layout.tsx
Outdated
| @@ -71,6 +72,7 @@ export const Layout = ({ | |||
| const basePath = 'docs.amplify.aws'; | |||
| const metaUrl = url ? url : basePath + asPathWithNoHash; | |||
| const pathname = router.pathname; | |||
| const shouldShowGen2Banner = asPathWithNoHash === '/'; | |||
There was a problem hiding this comment.
This isn't really related to gen2, this is an ai banner.
Suggested change
| const shouldShowGen2Banner = asPathWithNoHash === '/'; | |
| const shouldShowAIBanner = asPathWithNoHash === '/'; |
dindjarinjs
reviewed
Dec 10, 2024
src/components/Banner/Banner.tsx
Outdated
| url?: string; | ||
| } | ||
|
|
||
| export const Banner: React.FC<BannerProps> = ({ |
There was a problem hiding this comment.
This should just be called AIBanner since the content is hardcoded.
dindjarinjs
approved these changes
Dec 10, 2024
dbanksdesign
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This creates a new badge and message about AI kit. This will only appear on the homepage.
And a new New badge:
Dark mode
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)HTML:
<a href="https://docs.amplify.aws/">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.