Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrading to Amplify 2.16+ #38

Merged
merged 1 commit into from
Sep 13, 2023
Merged

chore: Upgrading to Amplify 2.16+ #38

merged 1 commit into from
Sep 13, 2023

Conversation

ruisebas
Copy link
Member

Description of changes:

This PR unpins the Amplify version and makes the necessary code changes in order to compile.

⚠️ Note: TOTP support (introduced in Amplify 2.16.0) is not yet supported.

This PR also fixes an issue when calling AuthenticatorState.setCurrentStep(_:) when the current state is .error: The if condition was not checking the current step value.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ruisebas ruisebas requested a review from harsh62 September 11, 2023 17:31
@ruisebas ruisebas requested review from a team as code owners September 11, 2023 17:31
Copy link
Member

@harsh62 harsh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruisebas ruisebas merged commit f4c015b into main Sep 13, 2023
1 check passed
@ruisebas ruisebas deleted the ruisebas/unpin_amplify branch September 13, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants