-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for email mfa #94
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruisebas
reviewed
Sep 13, 2024
Sources/Authenticator/States/ContinueSignInWithEmailMFASetupState.swift
Outdated
Show resolved
Hide resolved
Sources/Authenticator/States/ContinueSignInWithEmailMFASetupState.swift
Outdated
Show resolved
Hide resolved
Sources/Authenticator/States/ContinueSignInWithMFASetupSelectionState.swift
Outdated
Show resolved
Hide resolved
Sources/Authenticator/Views/ContinueSignInWithMFASetupSelectionView.swift
Outdated
Show resolved
Hide resolved
Sources/Authenticator/Views/ContinueSignInWithMFASetupSelectionView.swift
Outdated
Show resolved
Hide resolved
Sources/Authenticator/Views/ContinueSignInWithMFASetupSelectionView.swift
Outdated
Show resolved
Hide resolved
Sources/Authenticator/States/ContinueSignInWithMFASetupSelectionState.swift
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
==========================================
+ Coverage 41.81% 44.29% +2.48%
==========================================
Files 41 43 +2
Lines 1906 2472 +566
==========================================
+ Hits 797 1095 +298
- Misses 1109 1377 +268
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruisebas
reviewed
Oct 29, 2024
ruisebas
reviewed
Oct 29, 2024
ruisebas
reviewed
Oct 29, 2024
Co-authored-by: Sebastian Villena <[email protected]>
Co-authored-by: Sebastian Villena <[email protected]>
Co-authored-by: Sebastian Villena <[email protected]>
ruisebas
previously approved these changes
Oct 29, 2024
Sources/Authenticator/Views/Internal/ConfirmSignInWithCodeView.swift
Outdated
Show resolved
Hide resolved
ruisebas
reviewed
Oct 30, 2024
Sources/Authenticator/Views/Internal/ConfirmSignInWithCodeView.swift
Outdated
Show resolved
Hide resolved
Sources/Authenticator/Views/Internal/ConfirmSignInWithCodeView.swift
Outdated
Show resolved
Hide resolved
Sources/Authenticator/Views/Internal/ConfirmSignInWithCodeView.swift
Outdated
Show resolved
Hide resolved
Sources/Authenticator/Views/Internal/ConfirmSignInWithCodeView.swift
Outdated
Show resolved
Hide resolved
ruisebas
previously approved these changes
Oct 30, 2024
…ift-authenticator into feat/email-mfa
ruisebas
reviewed
Oct 31, 2024
ruisebas
previously approved these changes
Oct 31, 2024
ruisebas
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Email MFA:
With these changes we have also made sure that Amplify's latest changes to email MFA won't break existing Authenticator. So Authenticator can safely take on the new version of Amplify with the new steps.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.