Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for email mfa #94

Merged
merged 35 commits into from
Oct 31, 2024
Merged

feat: add support for email mfa #94

merged 35 commits into from
Oct 31, 2024

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Sep 13, 2024

Adding support for Email MFA:

With these changes we have also made sure that Amplify's latest changes to email MFA won't break existing Authenticator. So Authenticator can safely take on the new version of Amplify with the new steps.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@harsh62 harsh62 requested review from a team as code owners September 13, 2024 16:04
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 74.11765% with 22 lines in your changes missing coverage. Please review.

Project coverage is 44.29%. Comparing base (1ec95fb) to head (c3bfde4).

Files with missing lines Patch % Lines
...urces/Authenticator/Utilities/PreviewFactory.swift 0.00% 9 Missing ⚠️
Sources/Authenticator/Models/Internal/Step.swift 0.00% 6 Missing ⚠️
.../States/ContinueSignInWithEmailMFASetupState.swift 86.20% 4 Missing ⚠️
...tes/ContinueSignInWithMFASetupSelectionState.swift 93.33% 2 Missing ⚠️
.../Authenticator/States/AuthenticatorBaseState.swift 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   41.81%   44.29%   +2.48%     
==========================================
  Files          41       43       +2     
  Lines        1906     2472     +566     
==========================================
+ Hits          797     1095     +298     
- Misses       1109     1377     +268     
Flag Coverage Δ
Authenticator 44.29% <74.11%> (+2.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruisebas
ruisebas previously approved these changes Oct 30, 2024
ruisebas
ruisebas previously approved these changes Oct 31, 2024
@harsh62 harsh62 merged commit 541ec6e into main Oct 31, 2024
4 checks passed
@harsh62 harsh62 deleted the feat/email-mfa branch October 31, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants