Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add action workflow for ensuring minimum sdk version support #3462

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

5d
Copy link
Member

@5d 5d commented Jan 8, 2024

Issue #

Description

  • add action workflow for building package with minimum supported sdk version
    • when commit is pushing to main branch
    • also can dispatch on any branch manually

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@5d 5d force-pushed the 5d/ci-build-with-min-version branch from f3ee3d4 to 798504b Compare January 8, 2024 21:59
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2abaf4c) 68.06% compared to head (caaa159) 68.09%.
Report is 5 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3462      +/-   ##
==========================================
+ Coverage   68.06%   68.09%   +0.03%     
==========================================
  Files        1079     1079              
  Lines       36356    36356              
==========================================
+ Hits        24745    24758      +13     
+ Misses      11611    11598      -13     
Flag Coverage Δ
API_plugin_unit_test 67.07% <ø> (ø)
AWSPluginsCore 64.13% <ø> (ø)
Amplify 48.17% <ø> (+0.06%) ⬆️
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 78.98% <ø> (+0.01%) ⬆️
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.46% <ø> (+0.10%) ⬆️
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 63.34% <ø> (ø)
Predictions_plugin_unit_test 37.16% <ø> (ø)
PushNotifications_plugin_unit_test 87.13% <ø> (ø)
Storage_plugin_unit_test 77.51% <ø> (ø)
unit_tests 68.09% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@5d 5d marked this pull request as ready for review January 8, 2024 22:22
@5d 5d requested a review from a team as a code owner January 8, 2024 22:22
xcode-version: 14.0.1
platform: watchOS

uses: ./.github/workflows/build_amplify_swift.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling this workflow here as is will result in the build cache being overwritten.

You could add a new optional boolean input that allows to skip the Save the dependencies cache in main step in build_amplify_swift.yml.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! will update it.

@5d 5d force-pushed the 5d/ci-build-with-min-version branch from 42c4ee5 to 6328e51 Compare January 9, 2024 20:46
@5d 5d force-pushed the 5d/ci-build-with-min-version branch from 6328e51 to a1a66dd Compare January 9, 2024 20:49
@5d 5d force-pushed the 5d/ci-build-with-min-version branch from a1a66dd to b7d16b0 Compare January 9, 2024 20:50
@5d 5d force-pushed the 5d/ci-build-with-min-version branch from b7d16b0 to caaa159 Compare January 9, 2024 20:59
@5d 5d merged commit 0d8f12a into main Jan 9, 2024
78 checks passed
@5d 5d deleted the 5d/ci-build-with-min-version branch January 9, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants