-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In a multipart upload using Amplify.Storage.uploadFile, pre-signed URLs for each part should have 50 minute expiration from the time that each part is created instead of the time from which the first part is created #1838
Comments
@brennanMKE FYI |
Also , I am assuming that all the parts are not created at once. If they are then feel free to redo the bug. |
The way the SDK works has been this way for many years. The new Swift SDK will create the pre-signed URL just as the upload for a part is about to start, so it has the behavior that would handle the timeout better. If you'd like this update in the SDK please create a feature request. We are working on the Dev Preview for the new Amplify GA release which you may find will include many improvements that you want. |
@sagarjoshi WWDC starts Monday and I will try to get a lab session to discuss this issue. |
sorry, somehow I missed this. I thought #1838 was the feature request. Also please let us know the result of the discussion for https://github.com/aws-amplify/amplify-ios/discussions/1740 |
Hi ! Can this please be patched in the existing amplify library ? My users in Asia simply cannot upload large videos without getting timed out and starting all over again ( and failing again ) . |
@brennanMKE at-least this way it will take whatever it takes but actually finish . |
This has been identified as a feature request. If this feature is important to you, we strongly encourage you to give a 👍 reaction on the request. This helps us prioritize new features most important to you. Thank you! |
Definitely need this |
Cannot reliably upload large files without this |
@sagarjoshi we recently made improvements to speed at which uploads complete. Please see this comment for more information #1542 (comment) and let us know if updating resolves your issue. Thanks! |
Is your feature request related to a problem? Please describe.
I am hoping that this is a smaller fix than re-thinking the entire approach ( https://github.com/aws-amplify/amplify-ios/discussions/1740 ) which includes this idea + background uploads. Some of my users with poor upload bandwidth are running into timeout issues for large files.
Describe the solution you'd like
in the title :)
Describe alternatives you've considered
long discussion here around longer term approach ( https://github.com/aws-amplify/amplify-ios/discussions/1740 )
Is the feature request related to any of the existing Amplify categories?
Storage
Additional context
No response
The text was updated successfully, but these errors were encountered: