Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In a multipart upload using Amplify.Storage.uploadFile, pre-signed URLs for each part should have 50 minute expiration from the time that each part is created instead of the time from which the first part is created #1838

Closed
sagarjoshi opened this issue May 28, 2022 · 11 comments
Assignees
Labels
slow-transfer Slow uploads or downloads with S3 storage Issues related to the Storage category

Comments

@sagarjoshi
Copy link

Is your feature request related to a problem? Please describe.

I am hoping that this is a smaller fix than re-thinking the entire approach ( https://github.com/aws-amplify/amplify-ios/discussions/1740 ) which includes this idea + background uploads. Some of my users with poor upload bandwidth are running into timeout issues for large files.

Describe the solution you'd like

in the title :)

Describe alternatives you've considered

long discussion here around longer term approach ( https://github.com/aws-amplify/amplify-ios/discussions/1740 )

Is the feature request related to any of the existing Amplify categories?

Storage

Additional context

No response

@sagarjoshi sagarjoshi changed the title In a multipart upload using Amplify.Storage.uploadFile pre-signed URLs for each part should have 50 minute expiration from the time that each part is created instead of the time from which the first part is created In a multipart upload using Amplify.Storage.uploadFile, pre-signed URLs for each part should have 50 minute expiration from the time that each part is created instead of the time from which the first part is created May 28, 2022
@sagarjoshi
Copy link
Author

@brennanMKE FYI

@sagarjoshi
Copy link
Author

Also , I am assuming that all the parts are not created at once. If they are then feel free to redo the bug.

@brennanMKE brennanMKE added storage Issues related to the Storage category slow-transfer Slow uploads or downloads with S3 labels Jun 3, 2022
@brennanMKE
Copy link
Contributor

The way the SDK works has been this way for many years. The new Swift SDK will create the pre-signed URL just as the upload for a part is about to start, so it has the behavior that would handle the timeout better. If you'd like this update in the SDK please create a feature request. We are working on the Dev Preview for the new Amplify GA release which you may find will include many improvements that you want.

@brennanMKE
Copy link
Contributor

brennanMKE commented Jun 3, 2022

@sagarjoshi WWDC starts Monday and I will try to get a lab session to discuss this issue.

https://github.com/aws-amplify/amplify-ios/discussions/1740

@sagarjoshi
Copy link
Author

sorry, somehow I missed this. I thought #1838 was the feature request.

Also please let us know the result of the discussion for https://github.com/aws-amplify/amplify-ios/discussions/1740

@sagarjoshi
Copy link
Author

sagarjoshi commented Jun 16, 2022

Hi ! Can this please be patched in the existing amplify library ? My users in Asia simply cannot upload large videos without getting timed out and starting all over again ( and failing again ) .

@sagarjoshi
Copy link
Author

sagarjoshi commented Jun 16, 2022

@brennanMKE at-least this way it will take whatever it takes but actually finish .

@ukhan-amazon ukhan-amazon added the bug Something isn't working label Sep 20, 2022
@5d 5d added feature-request Request a new feature and removed bug Something isn't working labels Nov 21, 2022
@github-actions
Copy link
Contributor

This has been identified as a feature request. If this feature is important to you, we strongly encourage you to give a 👍 reaction on the request. This helps us prioritize new features most important to you. Thank you!

@sagarjoshi
Copy link
Author

Definitely need this

@sagarjoshi
Copy link
Author

Cannot reliably upload large files without this

@atierian
Copy link
Member

atierian commented May 3, 2023

@sagarjoshi we recently made improvements to speed at which uploads complete. Please see this comment for more information #1542 (comment) and let us know if updating resolves your issue. Thanks!

@atierian atierian added the closing soon This issue will be closed in 7 days unless further comments are made. label May 8, 2023
@atierian atierian self-assigned this May 20, 2023
@atierian atierian removed the feature-request Request a new feature label May 20, 2023
@github-actions github-actions bot removed the closing soon This issue will be closed in 7 days unless further comments are made. label May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
slow-transfer Slow uploads or downloads with S3 storage Issues related to the Storage category
Projects
None yet
Development

No branches or pull requests

5 participants