Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(auth): Reduce repetition in AWSCognitoAuthPlugin #2932

Merged
merged 2 commits into from
Oct 4, 2024
Merged

chore(auth): Reduce repetition in AWSCognitoAuthPlugin #2932

merged 2 commits into from
Oct 4, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Replace the repeated boilerplate in AWSCognitoAuthPlugin with some utility functions.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner September 26, 2024 15:27
@mattcreaser mattcreaser enabled auto-merge (squash) October 4, 2024 17:50
@mattcreaser mattcreaser merged commit c1030d4 into main Oct 4, 2024
3 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/auth-plugin-cleanup branch October 4, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phantumcode phantumcode phantumcode approved these changes

@vincetran vincetran vincetran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattcreaser @vincetran @phantumcode