Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(auth): Add waits to asynchronous tests #2924

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
I noticed that unit tests in RealAuthCognitoPluginTest were frequently failing on CI. Inspecting the failing tests show that they were not necessarily waiting for the callbacks to be invoked before proceeding with verification. Adding additional latches should resolve the issue.

Longer term this area of the codebase should be refactored into usecases.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner September 20, 2024 12:53
@mattcreaser mattcreaser enabled auto-merge (squash) September 20, 2024 14:31
@mattcreaser mattcreaser merged commit 14c71f3 into main Sep 20, 2024
4 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/cognito-plugin-test-fix branch September 20, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants