Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to CompileSDK 34 #2893

Merged
merged 17 commits into from
Aug 14, 2024
Merged

chore: Upgrade to CompileSDK 34 #2893

merged 17 commits into from
Aug 14, 2024

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • Upgrade Gradle to 8.7
  • Upgrade AGP to 8.4
  • Upgrade CompileSDK to 34

How did you test these changes?

  • Verified library built and published

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser changed the title chore: Upgrade to ComileSDK 34 chore: Upgrade to CompileSDK 34 Aug 12, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.96%. Comparing base (0f61cc8) to head (2b5e0af).
Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2893      +/-   ##
==========================================
+ Coverage   43.00%   43.96%   +0.95%     
==========================================
  Files         905      926      +21     
  Lines       29179    30481    +1302     
  Branches     4153     4350     +197     
==========================================
+ Hits        12549    13401     +852     
- Misses      15271    15621     +350     
- Partials     1359     1459     +100     

@mattcreaser mattcreaser marked this pull request as ready for review August 14, 2024 14:42
@mattcreaser mattcreaser requested a review from a team as a code owner August 14, 2024 14:42
@mattcreaser mattcreaser enabled auto-merge (squash) August 14, 2024 15:26
@mattcreaser mattcreaser merged commit a8a5d86 into main Aug 14, 2024
4 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/gradle-8 branch August 14, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants