Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(auth): update getCurrentUser to check for SessionExpiredException #2882

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

phantumcode
Copy link
Contributor

@phantumcode phantumcode commented Jul 30, 2024

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
Related issue in Amplify UI Android for Authenticator: aws-amplify/amplify-ui-android#145
Description of changes:

  • Update getCurrentUser to check and return SessionExpiredException to handle cases where users are signed in but the session has expired.

How did you test these changes?

  • manually tested with test app with Authenticator
  • verified unit test passed

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested a review from a team as a code owner July 30, 2024 14:58
@phantumcode phantumcode merged commit e25c0b4 into main Aug 15, 2024
3 checks passed
@phantumcode phantumcode deleted the phantum/getCurrentUser_update branch August 15, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants