Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Add missing JvmStatic annotations #2823

Merged
merged 3 commits into from
May 17, 2024
Merged

Conversation

tylerjroach
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
In conversion of ModelSubscription file from Java to Kotlin, JvmStatic annotations were missed, which make calling from Java more difficult. Adding JvmStatic back to re-introduce calling without requiring ModelSubscription.INSTANCE

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tylerjroach tylerjroach requested review from a team as code owners May 15, 2024 20:17
@mattcreaser mattcreaser changed the title Add missing JvmStatic annotations fix(api): Add missing JvmStatic annotations May 15, 2024
@mattcreaser mattcreaser merged commit d8fd864 into main May 17, 2024
3 checks passed
@mattcreaser mattcreaser deleted the tjroach/add-jvm-static branch May 17, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants