Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): Set start time before generating session ID #2747

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

mattcreaser
Copy link
Member

@mattcreaser mattcreaser commented Mar 28, 2024

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
#2746

Description of changes:
startTime should be set before generating a session ID

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner March 28, 2024 12:46
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.92%. Comparing base (6413dbc) to head (51f3b62).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2747      +/-   ##
==========================================
- Coverage   42.93%   42.92%   -0.01%     
==========================================
  Files         905      905              
  Lines       29127    29127              
  Branches     4144     4144              
==========================================
- Hits        12505    12504       -1     
- Misses      15267    15269       +2     
+ Partials     1355     1354       -1     

@tylerjroach tylerjroach merged commit e89fe42 into main Mar 28, 2024
3 checks passed
@tylerjroach tylerjroach deleted the mattcreaser/analytics-session-id branch March 28, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants