Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ignore variations of amplify_outputs #2962

Closed
wants to merge 1 commit into from

Conversation

vincetran
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: N/A

Description of changes: One of the new integration test files for Email MFA is amplify_outputs_email_or_totp_mfa.json which the current .gitignore doesn't catch

How did you test these changes?
Before: git wants to add amplify_outputs_email_or_totp_mfa.json
After: It doesn't see it

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran marked this pull request as ready for review December 3, 2024 22:55
@vincetran vincetran requested a review from a team as a code owner December 3, 2024 22:55
@mattcreaser
Copy link
Member

This is already open as part of #2961

@vincetran vincetran closed this Dec 4, 2024
@vincetran vincetran deleted the vincetran/add-amplify-outputs-to-gitignore branch December 4, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants