Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions is successful but it doesn't apply the changeset #122

Open
AyoubOukh opened this issue Jan 10, 2024 · 1 comment
Open

Actions is successful but it doesn't apply the changeset #122

AyoubOukh opened this issue Jan 10, 2024 · 1 comment

Comments

@AyoubOukh
Copy link

Hello,
We are seeing an issue where the action runs successfully but it doesn't apply the changeset, and therefore the changeset is not deleted - which causes errors in the following deployments:
ChangeSet ****-CS cannot be created due to a mismatch with existing attribute Template
This was quite unclear to debug, but I am positive that the previous run was successful and the changeset wasn't applied, although the CS was successfully created.

      - name: Deploy to AWS CloudFormation
        id: cloudformation_deploy_stacks
        uses: aws-actions/aws-cloudformation-github-deploy@v1
        with:
          name: ${{ matrix.pipelines.stack }}
          template: https://s3.amazonaws.com/${{ env.S3_BUCKET }}/${{ matrix.pipelines.stack }}/cfn-template.packaged.yml
          parameter-overrides: file://${{ matrix.pipelines.path }}/config/config.json
          capabilities: CAPABILITY_IAM,CAPABILITY_NAMED_IAM,CAPABILITY_AUTO_EXPAND
@CraigHead
Copy link

CraigHead commented Nov 22, 2024

I am also running into this. Except my exception is ChangeSet ****-CS cannot be created due to a mismatch with existing attribute Parameters. The behavior is the same. There is a changeset that is created but not executed. Also the changeset is not deleted ephemerally. When the stack gets into this state, future deployments are prevented from happening until someone manually cleans up the dirty Changeset.

IMHO this try-catch should really be a try-finally. https://github.com/aws-actions/aws-cloudformation-github-deploy/blob/master/src/deploy.ts#L85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants