"Winner" button shown to non-deans on a particular project

[mitcho]

Today during deliberations, many of us non-deans in Boston pulled up this page and noticed that the "winner" button was visible on this project:

http://www.awesomefoundation.org/en/chapters/boston/projects/18862

The button is not visible (as expected) for all other projects we have seen this evening.

[jcn]

I wonder if this is a byproduct of the project being submitted to the "Any" chapter. Can you confirm that the other projects which did not show the "winner" button were actually submitted to the Boston chapter?

[mitcho]

Ah! I see what is happening. If I visit the project with "any" in the path, which is what the listing of "Any" projects gives, it gives the correct project page. If I visit the project with "boston" in the path, the "winner" button is added. Note, though, that other chapter metadata on the page still correctly identifies the project as an "Any" project.

[mitcho]

Oh, it gets better! I can change the path to whatever chapter I want, and get a button to make an "Any" proposal a winner for a different chapter! For example, http://www.awesomefoundation.org/en/chapters/sf/projects/19163 gives me a "Winner for San Francisco" button. Of course, I didn't click on it... hopefully there are checks in the back of the button press which would prevent me from actually doing so...

[jcn]

OK, so there are two components here:

• First, this only happens because the project belongs to the "any" chapter. In this case, it can technically be assigned to be the winner for any of the chapters. Since the "any" chapter doesn't have any deans, apparently any user can mark it as a winner. We're actually planning on changing the functionality so that any user can actually assign the winner - since so many chapters have rotating dean / website responsibilities, limiting the functionality just to the dean is probably unnecessary
• Secondly, as you surmised, the button gets its text from the chapter that's in the path. And because of the way the functionality for the "any" projects is written, I believe you could actually set a project to be the winner for another chapter, which is not actually the correct functionality, even in the new model, so that bug definitely needs to be fixed

[karabee]

I can't find where in the repository this feature change is located to comment on, so I'm going to paste it here with an implementation request:

We're actually planning on changing the functionality so that any user can actually assign the winner - since so many chapters have rotating dean / website responsibilities, limiting the functionality just to the dean is probably unnecessary

*If it is implemented that EVERY user has access to the "Winner" button, can something be done to protect from accidental clicking of the "Winner" button?

If everyone had it, I would anticipate there would be a fair number of accidental "Winner" postings when people are clicking "Awesome" to nominate something for the shortlist and those accidental postings could lead to unfunded projects hearing through the grapevine that they were listed as being funded on our website...

Two ideas on how to avoid this:

1. Move the location of the button away from the Awesome button
2. Make it clear with a confirmation message that clicking that button means that the project is going to go "live" on the chapter page as a fellowship recipient
3. Bury this option as viewable only when a non-Dean user has clicked into the application. It would still be great to have the safeguard of ideas 1 and 2 in the implementation of a buried "Winner" button.

[jcn]

you could actually set a project to be the winner for another chapter

This bug has been fixed in #328. The rest of this is a non-bug, and the editing/marking as a winner was changed in #326 so I'm going to close this.